Mixed

What is the difference between pull request and issue?

by Author

What is the difference between pull request and issue?

The difference is quite clear: if you don’t think you can contribute back a patch, open a new issue (following the same kind of checklist than the one described here). if you think you can make some patch to fix the issue, fork the repo, and make a pull request (once you have pushed your patch back to your fork).

How many people should review a pull request?

There is usually one person that is the first to always review a PR and after this happens for many consecutive PRs, everyone expects the same person to review the pull request and then the requests for review end up getting ignored by most.

READ ALSO:   Is it possible to run 10 miles in an hour?

What should I comment on a pull request?

Effectively reviewing a PR

  1. Leave more questions than suggestions. Ask a lot.
  2. You can also leave compliments. I would highly encourage you to do so if you can.
  3. If it’s too big of a change.
  4. Don’t hide answers.
  5. Avoid using “YOU” as much as possible.

How big should a PR be?

Usually a PR should take < 8hrs (depending on your familiarity with the codebase). Use commits. If your PR feels a little big, split the changes into logical groups using git commits.

Can I approve my own pull request?

6 Answers. If you were the one who has committed the pull request you cannot approve or request changes on this pull request. It’s only available when someone else requested such action. So your only option is to comment it.

Who can approve pull request?

After a pull request is opened, anyone with read access can review and comment on the changes it proposes. You can also suggest specific changes to lines of code, which the author can apply directly from the pull request.

READ ALSO:   Does owing back taxes affect buying a house?

How do I comment on a pull request GitHub?

Adding line comments to a pull request On the pull request, click Files changed. Hover over the line of code where you’d like to add a comment, and click the blue comment icon. To add a comment on multiple lines, click and drag to select the range of lines, then click the blue comment icon.

Where are the comments on GitHub?

You can view all the issues on Github you have commented on by going to https://github.com/notifications/subscriptions and selecting Reason as Comment . This will show all the issues that you’ve commented on.