How do I find pull requests on GitHub?
Table of Contents
How do I find pull requests on GitHub?
Viewing a pull request in GitHub Desktop
- In GitHub Desktop, click Current Branch.
- At the top of the drop-down menu, click Pull Requests.
- In the list of pull requests, click the pull request you want to view.
- Optionally, to refresh the list of pull requests, click .
What makes a good pull request?
Recap
- Pull request size. It should be small.
- Feature breaking. Whenever possible, break pull-requests into smaller ones.
- Single Responsibility Principle. The pull request should do only one thing.
- Title. Make a self-explanatory title describing what the pull request does.
- Description.
What is considered a big pull request?
How can we determine the perfect pull request size? A study of a Cisco Systems programming team revealed that a review of 200-400 LOC over 60 to 90 minutes should yield 70-90\% defect discovery. With this number in mind, a good pull request should not have more than 250 lines of code changed.
How do I make a great pull request?
Here’s the result: Nine ways to make pull requests easier to review.
- Add “Why” Code Comments.
- Make Your PRs Small.
- Make a Clear Description.
- Comment Your Own Pull Request.
- Discuss the Overall Approach Before Implementing the Whole Feature.
- Rebase Onto Fresh Master Before Creating a PR.
- Respond to Reviews Quickly.
What is a pull request in GitHub?
Pull requests let you tell others about changes you’ve pushed to a branch in a repository on GitHub. Once a pull request is opened, you can discuss and review the potential changes with collaborators and add follow-up commits before your changes are merged into the base branch.
What is GitHub pull request?
Why pull requests should be small?
The size of a pull request can be influenced long before the PR is opened. Slice features small in your product backlog; make small commits along the way; combine small commits into small pull requests. Among other benefits, a focus on breaking work into small parts will make it easier to review your changes.
What should a pull request include?
Offering feedback
- Familiarize yourself with the context of the issue, and reasons why this Pull Request exists.
- If you disagree strongly, consider giving it a few minutes before responding; think before you react.
- Ask, don’t tell.
- Explain your reasons why code should be changed.
- Offer ways to simplify or improve code.